umustafi opened a new pull request, #3890:
URL: https://github.com/apache/gobblin/pull/3890

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   I create the following new classes:
   
   `InstrumentedLeaseArbiterDecorator` - a decorator around 
`MySqlMultiActiveLeaseArbiter` with metrics for lease attempts 
(`DagProcArbiterDecorator` & `FlowTriggerDecorator` will extend the common 
functionality)
   
   `DagProcArbiterDecorator` - child class of InstrumentedLeaseArbiterDecorator 
used for multi-active execution to set a reminder for a dagTask an instance 
failed to obtain a lease on.
   
   (existing class) FlowTriggerDecorator will contain similar logic for 
Multi-active scheduling.
   
   `DagProcReminderScheduler` - provides methods for adding reminders to the 
QuartzScheduler.
   
   I debated the following implementation details
   
   _Re-using the same QuartzScheduler and SchedulerService from 
GobblinServiceJobScheduler?_
   Because I want to avoid the confusion of having multiple job types in a 
single scheduler & in-memory QuartzSchedulers are pretty lightweight, I opted 
to create a separate scheduler to handle reminder events for multi-active 
execution lease arbitration. 
   
   
   _Use a different lease arbitration table and instance btwn the scheduler and 
execution arbitration phases._
   I create a separate lease arbiter instance and table for execution versus 
scheduler so we can more easily isolate & monitor issues between scheduler and 
execution lease arbitration in case the cases need to be handled differently. 
It also allows us to use the existing code with no changes to vary the 
epsilon/linger values for scheduling and execution (the latter should be much 
greater). 
   Note that we have to do the lease arbitration logic twice because we had 
separated the rollout of multi-active scheduler from executor. A future 
optimization would be to do de-duplication and consolidation before adding 
actions to the dagActionStore then arbitrate once to establish ownership of 
execution, but this will require significant investment to optimize working 
functionality so we leave this for the future.  
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to