phet commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1522517854


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerDecorator.java:
##########
@@ -64,43 +62,29 @@
  * in failure cases.
  */
 @Slf4j
-public class FlowTriggerHandler {
+public class FlowTriggerDecorator extends InstrumentedLeaseArbiterDecorator {

Review Comment:
   this naming suggests a type named `FlowTrigger` is to be decorated... 
although w/o specifying how.  (cf. `SelfHealingFlowTriggerDecorator`, 
`BufferingFlowTriggerDecorator`, etc.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to