phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522186274
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/PriorJobStateWUProcessingSpec.java:
##########
@@ -78,42 +78,13 @@ public boolean isToDoJobLevelTiming() {
try {
FileSystem fs = Help.loadFileSystemForce(this);
JobState jobState = Help.loadJobStateUncached(this, fs);
- List<Tag<?>> tagsFromCurrentJob = this.getTags();
- String metricsSuffix = this.getMetricsSuffix();
- List<Tag<?>> tags = this.calcMergedTags(tagsFromCurrentJob,
metricsSuffix, jobState);
- return new EventSubmitterContext(tags, JobMetrics.NAMESPACE);
+ return new EventSubmitterContext.Builder()
+ .addTags(this.getTags())
+ .withGaaSJobProps(jobState.getProperties())
Review Comment:
got it... I guess I mistook the purpose of `withGaaSJobProps`, and thought
at least some might overwrite those already in tags... thanks for clearing up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
