phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522186988
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/EventSubmitterContext.java:
##########
@@ -79,6 +73,76 @@ private static Class resolveClass(String canonicalClassName)
{
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}
+ }
+
+ @AllArgsConstructor
+ @NoArgsConstructor
+ public static class Builder {
+ private List<Tag<?>> tags = new ArrayList<>();
+ private String namespace;
+ public Builder(EventSubmitter eventSubmitter) {
+ this.tags.addAll(eventSubmitter.getTags());
+ this.namespace = eventSubmitter.getNamespace();
+ }
+ public Builder addTag(Tag<?> tag) {
Review Comment:
ctor needs a blank line before and after
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/EventSubmitterContext.java:
##########
@@ -17,18 +17,26 @@
package org.apache.gobblin.temporal.workflows.metrics;
+import com.google.common.collect.ImmutableList;
+import java.util.ArrayList;
Review Comment:
import order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
