phet commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1538723181
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -192,6 +193,15 @@ private void submitJobToExecutor(DagManagementStateStore
dagManagementStateStore
}
}
+ @Override
protected void sendNotification(Optional<Dag<JobExecutionPlan>> result,
EventSubmitter eventSubmitter) {
}
+
+ @Override
+ protected void commit(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> result) {
+ // Only call conclude method if multi-active execution enabled
+ if (this.isMultiActiveExecutionEnabled) {
+ this.launchDagTask.conclude();
+ }
+ }
Review Comment:
actually, why shouldn't it be safe to call `DagTask::conclude` even if not
MA exec? (i.e. drop the `isMAExecEnabled` member)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
