umustafi commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1540176216
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -192,6 +193,15 @@ private void submitJobToExecutor(DagManagementStateStore
dagManagementStateStore
}
}
+ @Override
protected void sendNotification(Optional<Dag<JobExecutionPlan>> result,
EventSubmitter eventSubmitter) {
}
+
+ @Override
+ protected void commit(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> result) {
+ // Only call conclude method if multi-active execution enabled
+ if (this.isMultiActiveExecutionEnabled) {
+ this.launchDagTask.conclude();
+ }
+ }
Review Comment:
We could call conclude and instead have a check at the `DagTask` level which
checks if an arbiter exists, if it does then call `concludeLease` and otherwise
do a no-op (because we use a dummy `LeaseObtainedStatus` for non MA execution
use)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
