[jira] [Work logged] (GOBBLIN-2022) create dag proc for taking actions on job completion

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911723
 ]

ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/24 05:41
            Start Date: 27/Mar/24 05:41
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540495842


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -46,18 +50,21 @@ public final void process(DagManagementStateStore 
dagManagementStateStore) throw
     S state = initialize(dagManagementStateStore);   // todo - retry
     T result = act(dagManagementStateStore, state);   // todo - retry
     commit(dagManagementStateStore, result);   // todo - retry
-    sendNotification(result, eventSubmitter);   // todo - retry
     log.info("{} successfully concluded actions for dagId : {}", 
getClass().getSimpleName(), getDagId());
   }
 
-  protected abstract DagManager.DagId getDagId();
+  protected DagManager.DagId getDagId() {
+    return this.dagTask.getDagId();
+  }
+
+  protected DagNodeId getDagNodeId() {
+    return this.dagTask.getDagNodeId();
+  }

Review Comment:
   in a perfect world we'd have reuse by implementing `FlowId`, `DagId`, and 
`DagNodeId` in terms of each other (using OO composition).  e.g.:
   ```
   @Data
   class DagId {
     private final FlowId flowId;
     private final String flowExecutionId;
   
    // (if desired...)
     public String getFlowGroup() {
       return flowId.getFlowGroup();
     }
     public String getFlowName() {
       return flowId.getFlowName();
     }
   }





Issue Time Tracking
-------------------

    Worklog Id:     (was: 911723)
    Time Spent: 9h 10m  (was: 9h)

> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
>                 Key: GOBBLIN-2022
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 9h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)