[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911739
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/24 06:47
Start Date: 27/Mar/24 06:47
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1540538026
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java:
##########
@@ -51,6 +51,7 @@ public void setUp() throws Exception {
ConfigValueFactory.fromAnyRef(stateStoreDir));
this.jobStatusRetriever = new FsJobStatusRetriever(config,
mock(MultiContextIssueRepository.class));
this.mysqlDagActionStore = mock(MysqlDagActionStore.class);
+ // job status monitor stores dag action into dag action store, so need to
mock that behavior to avoid NPE
Review Comment:
I did initially suggest adding such a comment, but as I just mentioned, my
opinion has evolved. the need for mocking here seems a code smell that
`KJSM::addJobStatusToStateStore` is doing too much and ought to be reworked.
following that, no mocking or comment would be required
Issue Time Tracking
-------------------
Worklog Id: (was: 911739)
Time Spent: 10h 50m (was: 10h 40m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
