rongshen opened a new pull request, #3910: URL: https://github.com/apache/gobblin/pull/3910
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): This PR resolves the issue identified https://jira01.corp.linkedin.com:8443/browse/ETL-15191. To clean up corrupted files during container restart, PR https://github.com/linkedin-multiproduct/gobblin-kafka/pull/119 is created to delete taskOutput folder upon restart. While testing it is noticed that sometimes a container in the shutdown can still run even though the task has been reassigned by Helix. Thus this PR is created to make sure taskOutput path is unique on for every task via appending taskAttemptId to the path. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Unit test added: KafkaStreamingExtractorTest.testWriteOutputDirUpdate - verified if config.WRITER_OUTPUT_DIR_UPDATE_ENABLED is set to false, there is no change to taskOutput dir - verified if config.WRITER_OUTPUT_DIR_UPDATE_ENABLED is set to true, taskAttemptId is appened to taskOutput end to end test performed: <img width="1339" alt="Screenshot 2024-03-29 at 10 48 47 AM" src="https://github.com/apache/gobblin/assets/7811200/b964e1d8-39cf-499b-b85c-c59ec5434065";> ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
