homatthew commented on code in PR #3910: URL: https://github.com/apache/gobblin/pull/3910#discussion_r1548299151
########## gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/FlushingExtractor.java: ########## @@ -88,6 +90,9 @@ public abstract class FlushingExtractor<S, D> extends EventBasedExtractor<S, D> public static final String WATERMARK_COMMIT_TIME_METRIC = "state.store.metrics.watermarkCommitTime"; public static final String COMMIT_STEP_METRIC_PREFIX = "commit.step."; + public static final String WRITER_OUTPUT_DIR_UPDATE_ENABLED = Review Comment: I don't think this name in isolation properly describes what the feature flag enables. I.e. `extractor.writerOutputDirUpdateEnabled` implies we are updating the output dir. But why are we updating it? And it also seems to imply it may work for all extractors, but this is specific to the flushing extractor. The goal is to give a unique output directory based on the current task attempt id. So the config name should give a hint to that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
