[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=912547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912547
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/24 00:03
Start Date: 02/Apr/24 00:03
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1546983962
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStore.java:
##########
@@ -201,8 +210,13 @@ public boolean containsDag(DagManager.DagId dagId) throws
IOException {
}
@Override
- public Optional<Dag.DagNode<JobExecutionPlan>> getDagNode(DagNodeId
dagNodeId) {
- return Optional.of(this.dagNodes.get(dagNodeId));
+ public Optional<Pair<Dag.DagNode<JobExecutionPlan>, JobStatus>>
getDagNodeWithJobStatus(DagNodeId dagNodeId) {
Review Comment:
making both params optional
Issue Time Tracking
-------------------
Worklog Id: (was: 912547)
Time Spent: 11.5h (was: 11h 20m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
