arjun4084346 commented on code in PR #3913:
URL: https://github.com/apache/gobblin/pull/3913#discussion_r1550696126
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java:
##########
@@ -155,6 +155,9 @@ public Void call() throws Exception {
public void onFailure(Throwable throwable) {
DatasetCleaner.this.finishCleanSignal.get().countDown();
LOG.warn("Exception caught when cleaning " + dataset.datasetURN() +
".", throwable);
+ if (throwable instanceof OutOfMemoryError) {
Review Comment:
how come the job exits successfully when the throwable is added to
`throwables` and a `RuntimeException` is thrown in `close`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
