arjun4084346 commented on code in PR #3913: URL: https://github.com/apache/gobblin/pull/3913#discussion_r1552061778
########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/MultiVersionCleanableDatasetBase.java: ########## @@ -322,12 +322,14 @@ public void clean() } private boolean cleanDatasetVersions(List<T> versions, VersionSelectionPolicy<T> selectionPolicy, - List<RetentionAction> retentionActions) + List<RetentionAction> retentionActions, boolean shouldLogDeletableVersion) Review Comment: a better name could have been `runningInBatches` `runningInAnIterator` or something like that. I mean it would be better to name it based on the condition/cause, not the effect we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
