[ 
https://issues.apache.org/jira/browse/GOBBLIN-2039?focusedWorklogId=914053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914053
 ]

ASF GitHub Bot logged work on GOBBLIN-2039:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/24 00:44
            Start Date: 11/Apr/24 00:44
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3918:
URL: https://github.com/apache/gobblin/pull/3918#discussion_r1560223194


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -136,7 +136,7 @@ public Optional<Dag<JobExecutionPlan>> 
validateAndHandleConcurrentExecution(Conf
         ConfigurationKeys.FLOW_ALLOW_CONCURRENT_EXECUTION, 
String.valueOf(this.isFlowConcurrencyEnabled)));
 
     Dag<JobExecutionPlan> jobExecutionPlanDag = 
specCompiler.compileFlow(flowSpec);
-    if (jobExecutionPlanDag.isEmpty()) {
+    if (jobExecutionPlanDag == null || jobExecutionPlanDag.isEmpty()) {

Review Comment:
   NPE was always possible here but unhandled.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 914053)
    Time Spent: 20m  (was: 10m)

> Handle edge cases in compilation and startup of dag action change store 
> monitor
> -------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2039
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2039
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> DagActionChangeStoreMonitor will try to load all the dag actions in the mysql 
> db on startup and submit them to the dagmanager.
> Sometimes there are issues during this startup process that can cause errors, 
> we want to handle these issues gracefully and not block the dag action change 
> monitor from initialization, otherwise it will block any dags from being 
> processed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to