[
https://issues.apache.org/jira/browse/GOBBLIN-2039?focusedWorklogId=914272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914272
]
ASF GitHub Bot logged work on GOBBLIN-2039:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/24 19:47
Start Date: 11/Apr/24 19:47
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3918:
URL: https://github.com/apache/gobblin/pull/3918#discussion_r1561564212
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -144,7 +144,12 @@ protected void initializeMonitor() {
}
// TODO: make this multi-threaded to add parallelism
for (DagActionStore.DagAction action : dagActions) {
- handleDagAction(action, true);
+ try {
+ handleDagAction(action, true);
+ } catch (Exception e) {
+ log.error("Ran into an unexpected error processing DagActionStore
changes during initialization for action {}", action, e);
Review Comment:
nit: leave out, "Ran into an "
maybe
```
"Unexpected error initializing from DagActionStore changes, with {}"
```
?
Issue Time Tracking
-------------------
Worklog Id: (was: 914272)
Time Spent: 50m (was: 40m)
> Handle edge cases in compilation and startup of dag action change store
> monitor
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-2039
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2039
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> DagActionChangeStoreMonitor will try to load all the dag actions in the mysql
> db on startup and submit them to the dagmanager.
> Sometimes there are issues during this startup process that can cause errors,
> we want to handle these issues gracefully and not block the dag action change
> monitor from initialization, otherwise it will block any dags from being
> processed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)