[
https://issues.apache.org/jira/browse/GOBBLIN-2043?focusedWorklogId=914990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914990
]
ASF GitHub Bot logged work on GOBBLIN-2043:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/24 23:01
Start Date: 16/Apr/24 23:01
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3922:
URL: https://github.com/apache/gobblin/pull/3922#discussion_r1568021703
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -146,6 +151,13 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
}
}
+ // Only set permission for newly created folders on target
Review Comment:
Yup, added the comment. We should be handling folders in the manifest with
https://github.com/apache/gobblin/blob/99c5a76e2b6193a8c78053b4e618ededfccbd3aa/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java#L195
Issue Time Tracking
-------------------
Worklog Id: (was: 914990)
Time Spent: 0.5h (was: 20m)
> Manifest distcp sets permissions of folders incorrectly starting from root
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2043
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2043
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Manifest distcp has a condition where it would set permissions of folders
> with an extra execute bit for recursive rename publishing to work, and we and
> would need to unset them to a correct permission through a commit step.
> However process should not be applying to folders that already exist on
> source, and we also want to avoid continuously looking at permissions for
> paths already calculated at source.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
