Will-Lo commented on code in PR #3933:
URL: https://github.com/apache/gobblin/pull/3933#discussion_r1577088631
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java:
##########
@@ -67,8 +74,9 @@ public static OpenTelemetryMetrics getInstance(State state) {
@Override
protected void initialize(State state) {
- Properties metricProps =
PropertiesUtils.extractPropertiesWithPrefix(state.getProperties(), Optional.of(
- ConfigurationKeys.METRICS_REPORTING_OPENTELEMETRY_CONFIGS));
+ log.info("Initializing OpenTelemetry metrics");
+ Properties metricProps =
PropertiesUtils.extractPropertiesWithPrefixAfterRemovingPrefix(state.getProperties(),
Review Comment:
Ah good point, changed to `extractChildProperties`
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/GaaSObservabilityProducerTest.java:
##########
@@ -54,6 +55,7 @@
import org.apache.gobblin.service.ServiceConfigKeys;
import org.apache.gobblin.service.modules.orchestration.AzkabanProjectConfig;
import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+import org.apache.gobblin.util.PropertiesUtils;
Review Comment:
Oops forgot to commit them after cleaning them up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
