Will-Lo commented on code in PR #3933:
URL: https://github.com/apache/gobblin/pull/3933#discussion_r1577089041
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -908,13 +908,19 @@ public class ConfigurationKeys {
public static final String METRICS_REPORTING_OPENTELEMETRY_ENABLED =
METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemtry.metrics.enabled";
- public static final String METRICS_REPORTING_OPENTELEMETRY_CONFIGS =
- METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemetry.configs";
+ public static final String METRICS_REPORTING_OPENTELEMETRY_CONFIGS_PREFIX =
+ METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemetry.configs.";
public static final Boolean DEFAULT_METRICS_REPORTING_OPENTELEMETRY_ENABLED
= false;
public static final String METRICS_REPORTING_OPENTELEMETRY_ENDPOINT =
METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemetry.endpoint";
+ public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_KEY =
+ METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemetry.header.key";
+
+ public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_VALUE =
+ METRICS_CONFIGURATIONS_PREFIX + "reporting.opentelemetry.header.value";
Review Comment:
I changed this to make all the configs use the same prefix of
`metrics.reporting.opentelemetry`
Before the prefix was just `metrics.` but realized this makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
