phet commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -219,8 +199,6 @@ private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
public AddSpecResponse onAddSpec(Spec addedSpec) {
if (addedSpec instanceof FlowSpec) {
return onAddFlowSpec((FlowSpec) addedSpec);
- } else if (addedSpec instanceof TopologySpec) {
- return onAddTopologySpec( (TopologySpec) addedSpec);
Review Comment:
I equate topologies w/ executors in the flow graph. since the FG can change
dynamically w/o requiring a system restart, it doesn't seem out of the question
to change the set of topos w/o a system restart either.
I agree that's not what we've done thus far, but it's arguably inconvenient
to require two separate changes to define a new executor - one to the FG and
one to the gaas configs. if it were possible to do both together, I would
personally find that appealing
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -219,8 +199,6 @@ private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
public AddSpecResponse onAddSpec(Spec addedSpec) {
if (addedSpec instanceof FlowSpec) {
return onAddFlowSpec((FlowSpec) addedSpec);
- } else if (addedSpec instanceof TopologySpec) {
- return onAddTopologySpec( (TopologySpec) addedSpec);
Review Comment:
I equate topology specs w/ executors in the flow graph. since the FG can
change dynamically w/o requiring a system restart, it doesn't seem out of the
question to change the set of topos w/o a system restart either.
I agree that's not what we've done thus far, but it's arguably inconvenient
to require two separate changes to define a new executor - one to the FG and
one to the gaas configs. if it were possible to do both together, I would
personally find that appealing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
