arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586717102
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -244,9 +250,10 @@ public void createTopologySpec() {
}
// Make sure TopologyCatalog is empty
Assert.assertTrue(specs.size() == 0, "Spec store should be empty before
addition");
- // Make sure TopologyCatalog Listener is empty
- Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 0,
"SpecCompiler should not know about any Topology "
- + "before addition");
+ Assert.assertTrue(specCompiler.getTopologySpecMap().size() == 1,
"SpecCompiler should know about any Topology "
Review Comment:
"SpecCompiler should know about any Topology irrespective of what is there
in the topology catalog" ? how does that sound like test should be `>1` ? What
description do you suggest?
There is no precondition. SpecCompiler should just know about the
topologies. Number of topologies known to spec compiler should just always be 1
(equals to total number of topologies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
