[
https://issues.apache.org/jira/browse/GOBBLIN-2064?focusedWorklogId=918219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918219
]
ASF GitHub Bot logged work on GOBBLIN-2064:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/24 01:02
Start Date: 08/May/24 01:02
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3945:
URL: https://github.com/apache/gobblin/pull/3945
…son builder
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2064
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
The GaaSObservabilityProducer uses
```
.setJobProperties(GsonUtils.GSON_WITH_DATE_HANDLING.newBuilder().create().toJson(jobProperties))
```
but this actually uses a newer version of GSON than the one defined in
Gobblin and used in some client systems that rely on an earlier version of
Gson. Since this fix is simple, we want to avoid version ambiguity when
possible and use the API of the version that we define in Gobblin.
```
.setJobProperties(GsonUtils.GSON_WITH_DATE_HANDLING.toJson(jobProperties))
```
Also cleanup some classnames to use the imported class rather than the fully
qualified classname which intellij automatically uses when changing class names
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 918219)
Remaining Estimate: 0h
Time Spent: 10m
> Use proper GSON builder in GaaSObservabilityEvent
> -------------------------------------------------
>
> Key: GOBBLIN-2064
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2064
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Using Gson.newBuilder() is only supported in Gson version 2.8.5 and above and
> not supported in the current version of 2.6.2 which Gobblin is on, so it was
> brought in by a transitive jar.
> We want to maintain the current version so that downstream dependencies that
> use Gobblin do not need to bump their version of Gson in case that causes
> incompatibility issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
