[
https://issues.apache.org/jira/browse/GOBBLIN-2064?focusedWorklogId=918369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918369
]
ASF GitHub Bot logged work on GOBBLIN-2064:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/24 15:35
Start Date: 08/May/24 15:35
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3945:
URL: https://github.com/apache/gobblin/pull/3945#discussion_r1594241136
##########
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/KafkaAvroJobStatusMonitorTest.java:
##########
@@ -339,8 +339,7 @@ public void
testProcessingRetriedForApparentlyTransientErrors() throws IOExcepti
Config conf = ConfigFactory.empty().withValue(
KafkaJobStatusMonitor.JOB_STATUS_MONITOR_PREFIX + "." +
RETRY_MULTIPLIER,
ConfigValueFactory.fromAnyRef(TimeUnit.MILLISECONDS.toMillis(1L)));
MockKafkaAvroJobStatusMonitor jobStatusMonitor =
createMockKafkaAvroJobStatusMonitor(shouldThrowFakeExceptionInParseJobStatusToggle,
conf,
- new
org.apache.gobblin.service.monitoring.NoopGaaSJobObservabilityEventProducer());
- jobStatusMonitor.buildMetricsContextAndMetrics();
+ new NoopGaaSJobObservabilityEventProducer()ntextAndMetrics();
Review Comment:
Yeah for some reason my intellij has not been playing well with any sort of
replacements, fixed
Issue Time Tracking
-------------------
Worklog Id: (was: 918369)
Time Spent: 0.5h (was: 20m)
> Use proper GSON builder in GaaSObservabilityEvent
> -------------------------------------------------
>
> Key: GOBBLIN-2064
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2064
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Using Gson.newBuilder() is only supported in Gson version 2.8.5 and above and
> not supported in the current version of 2.6.2 which Gobblin is on, so it was
> brought in by a transitive jar.
> We want to maintain the current version so that downstream dependencies that
> use Gobblin do not need to bump their version of Gson in case that causes
> incompatibility issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
