[
https://issues.apache.org/jira/browse/GOBBLIN-2066?focusedWorklogId=919211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919211
]
ASF GitHub Bot logged work on GOBBLIN-2066:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/24 22:46
Start Date: 13/May/24 22:46
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3912:
URL: https://github.com/apache/gobblin/pull/3912#discussion_r1599168187
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/ProcessWorkUnitsWorkflow.java:
##########
@@ -29,5 +30,5 @@
public interface ProcessWorkUnitsWorkflow {
/** @return the number of {@link WorkUnit}s cumulatively processed
successfully */
@WorkflowMethod
- int process(WUProcessingSpec wuSpec);
+ CommitGobblinStats process(WUProcessingSpec wuSpec);
Review Comment:
in lieu of my last comment, IMO `CommitStats` would read nicely here
Issue Time Tracking
-------------------
Worklog Id: (was: 919211)
Time Spent: 50m (was: 40m)
> Add Dataset level metrics in Temporal
> -------------------------------------
>
> Key: GOBBLIN-2066
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2066
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Temporal workflows can have added observability metrics so that workflows can
> be easily understood at-a-glance which is an improvement over the current
> Gobblin system.
> We want to provide the following:
> 1. Emit dataset-level metrics on job metadata as a GobblinTrackingEvent (to
> reach feature parity with existing Gobblin)
> 2. Enhance return types on Temporal so that users and service operators can
> easily view metadata on jobs being run, so that it becomes obvious when a job
> actually commits work and to which datasets without checking the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
