[
https://issues.apache.org/jira/browse/GOBBLIN-2066?focusedWorklogId=919389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919389
]
ASF GitHub Bot logged work on GOBBLIN-2066:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/24 20:34
Start Date: 14/May/24 20:34
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3912:
URL: https://github.com/apache/gobblin/pull/3912#discussion_r1600607252
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/CommitStats.java:
##########
@@ -17,17 +17,28 @@
package org.apache.gobblin.temporal.ddm.work;
+import java.util.HashMap;
import java.util.Map;
import lombok.Data;
import lombok.NoArgsConstructor;
import lombok.NonNull;
import lombok.RequiredArgsConstructor;
+
+/**
+ * Data structure representing the stats for a committed dataset, and the
ottal number of committed workunits in the Gobblin Temporal job
Review Comment:
"ottal" => "total"
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/DatasetStats.java:
##########
@@ -22,13 +22,17 @@
import lombok.NonNull;
import lombok.RequiredArgsConstructor;
+
+/**
+ * Stats for a dataset that was committed.
Review Comment:
"committed" or merely "processed"? e.g. is it not possible for
`successfullyCommitted == false` and `numCommittedWorkunits == 0`?
also, looks like a stray blank line in the javadoc comment
Issue Time Tracking
-------------------
Worklog Id: (was: 919389)
Time Spent: 1.5h (was: 1h 20m)
> Add Dataset level metrics in Temporal
> -------------------------------------
>
> Key: GOBBLIN-2066
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2066
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Temporal workflows can have added observability metrics so that workflows can
> be easily understood at-a-glance which is an improvement over the current
> Gobblin system.
> We want to provide the following:
> 1. Emit dataset-level metrics on job metadata as a GobblinTrackingEvent (to
> reach feature parity with existing Gobblin)
> 2. Enhance return types on Temporal so that users and service operators can
> easily view metadata on jobs being run, so that it becomes obvious when a job
> actually commits work and to which datasets without checking the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
