[ 
https://issues.apache.org/jira/browse/GOBBLIN-2067?focusedWorklogId=919378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919378
 ]

ASF GitHub Bot logged work on GOBBLIN-2067:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/May/24 19:12
            Start Date: 14/May/24 19:12
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3947:
URL: https://github.com/apache/gobblin/pull/3947#discussion_r1600527923


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -117,7 +117,7 @@ public class GobblinServiceManager implements 
ApplicationLauncher, StandardMetri
   public static final String SERVICE_EVENT_BUS_NAME = 
"GobblinServiceManagerEventBus";
 
   private static final Logger LOGGER = 
LoggerFactory.getLogger(GobblinServiceManager.class);
-  private static volatile GobblinServiceGuiceModule 
GOBBLIN_SERVICE_GUICE_MODULE;
+  @Setter private static volatile GobblinServiceGuiceModule 
GOBBLIN_SERVICE_GUICE_MODULE;

Review Comment:
   it will be used in li-gobblin.
   ```
   * If {@link GobblinServiceManager} is created using guice, user should set 
{@link GobblinServiceManager#GOBBLIN_SERVICE_GUICE_MODULE}
      * for this method to work.
   ```
   is the for that li-gobblin code





Issue Time Tracking
-------------------

    Worklog Id:     (was: 919378)
    Time Spent: 20m  (was: 10m)

> do not try to get dags during MostlyMySqlDagManagementStateStore 
> initialization
> -------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2067
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2067
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to