[ 
https://issues.apache.org/jira/browse/GOBBLIN-2067?focusedWorklogId=919387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919387
 ]

ASF GitHub Bot logged work on GOBBLIN-2067:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/May/24 20:28
            Start Date: 14/May/24 20:28
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3947:
URL: https://github.com/apache/gobblin/pull/3947#discussion_r1600605438


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -117,7 +117,7 @@ public class GobblinServiceManager implements 
ApplicationLauncher, StandardMetri
   public static final String SERVICE_EVENT_BUS_NAME = 
"GobblinServiceManagerEventBus";
 
   private static final Logger LOGGER = 
LoggerFactory.getLogger(GobblinServiceManager.class);
-  private static volatile GobblinServiceGuiceModule 
GOBBLIN_SERVICE_GUICE_MODULE;
+  @Setter private static volatile GobblinServiceGuiceModule 
GOBBLIN_SERVICE_GUICE_MODULE;

Review Comment:
   gotcha.  probably deserves a comment like:
   ```
   `@Setter` for use by downstream deployment code (beyond this repo)
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 919387)
    Time Spent: 40m  (was: 0.5h)

> do not try to get dags during MostlyMySqlDagManagementStateStore 
> initialization
> -------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2067
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2067
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to