[
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=920471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920471
]
ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/24 17:44
Start Date: 22/May/24 17:44
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1610404908
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java:
##########
@@ -168,6 +167,7 @@ public class GobblinServiceManager implements
ApplicationLauncher, StandardMetri
@Inject
@Getter
private Injector injector;
+ @Getter @Setter private volatile static Injector staticInjector;
Review Comment:
use Injector instead of GobblinServiceGuiceModule because use of latter
creates new instances of even classes marked as Singular and also takes really
long time because it processes all the bindings and create injector again for
every call to `getClass`
Issue Time Tracking
-------------------
Worklog Id: (was: 920471)
Time Spent: 3h (was: 2h 50m)
> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
> Key: GOBBLIN-2069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
