[ 
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=920484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920484
 ]

ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/May/24 18:58
            Start Date: 22/May/24 18:58
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1610501048


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -124,9 +131,18 @@ public DagTask next() {
       while (true) {
         try {
           DagActionStore.DagAction dagAction = this.dagActionQueue.take();
-          LeaseAttemptStatus leaseAttemptStatus = 
retrieveLeaseStatus(dagAction);
-          if (leaseAttemptStatus instanceof 
LeaseAttemptStatus.LeaseObtainedStatus) {
-            return createDagTask(dagAction, 
(LeaseAttemptStatus.LeaseObtainedStatus) leaseAttemptStatus);
+          // create triggers for original (non-reminder) dag actions of type 
ENFORCE_JOB_START_DEADLINE and ENFORCE_FLOW_FINISH_DEADLINE
+          // reminder triggers are used to inform hosts once the deadline for 
ENFORCE_JOB_START and ENFORCE_FLOW_FINISH passed

Review Comment:
   yea, either "deadline for ENFORCE_JOB_START" or ENFORCE_JOB_START_DEADLINE





Issue Time Tracking
-------------------

    Worklog Id:     (was: 920484)
    Time Spent: 4h  (was: 3h 50m)

> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
>                 Key: GOBBLIN-2069
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to