[
https://issues.apache.org/jira/browse/GOBBLIN-2069?focusedWorklogId=920536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920536
]
ASF GitHub Bot logged work on GOBBLIN-2069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/24 00:38
Start Date: 23/May/24 00:38
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3950:
URL: https://github.com/apache/gobblin/pull/3950#discussion_r1610817832
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -138,7 +138,11 @@ public DagTask next() {
createJobStartDeadlineTrigger(dagAction);
} else if (!dagAction.isReminder() && dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_FLOW_FINISH_DEADLINE) {
createFlowFinishDeadlineTrigger(dagAction);
- } else {
+ } else if (!dagAction.isReminder
+ || dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_FLOW_FINISH_DEADLINE
+ || dagAction.dagActionType ==
DagActionStore.DagActionType.ENFORCE_JOB_START_DEADLINE) {
+ // todo - fix bug of a reminder event getting a lease even when
the first attempt succeeded.
+ // for now, avoid processing reminder events if they are not for
deadline dag actions
Review Comment:
I will address this problem in a separate PR for now this will simply give
parity to existing functionality (no MA)
Issue Time Tracking
-------------------
Worklog Id: (was: 920536)
Time Spent: 4h 50m (was: 4h 40m)
> implement EnforceStartDeadlineDagProc
> -------------------------------------
>
> Key: GOBBLIN-2069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
