umustafi commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1621444363
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlMultiActiveLeaseArbiterTest.java:
##########
@@ -264,12 +269,19 @@ public void
testConditionallyAcquireLeaseIfFinishedLeasingStatement()
*/
@Test (dependsOnMethods =
"testConditionallyAcquireLeaseIfFinishedLeasingStatement")
public void testOlderReminderEventAcquireLease() throws IOException {
+ // Use current time as flowName to create unique event
+ DagActionStore.DagAction newLaunchAction = new
DagActionStore.DagAction(flowGroup,
+ String.valueOf(System.currentTimeMillis()), flowExecutionId, jobName,
DagActionStore.DagActionType.LAUNCH);
Review Comment:
I want to repeatedly obtain a unique string to use for flow name and don't
want these variables accidentally reused between tests. I could also use `UUID
uuid = UUID.randomUUID(); String name = uuid.toString().substring(0, 5);` but
they will also be unknown. The point of the tests are that we want to know
whether it's a unique dagAction or one seen before not really what the value of
the name is. Are you worried that the name may not be unique this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
