umustafi commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1640354522
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -117,20 +119,29 @@ public static String
createDagActionReminderKey(DagActionStore.DagAction dagActi
dagAction.getFlowExecutionId(), dagAction.getJobName(),
dagAction.getDagActionType());
}
+ /**
+ * Creates a JobKey object for the reminder job where the name is the
DagActionReminderKey from above and the group is
+ * the flowGroup
+ */
+ public static JobKey createJobKey(DagActionStore.DagAction dagAction) {
+ return new JobKey(createDagActionReminderKey(dagAction),
dagAction.getFlowGroup());
Review Comment:
if deadline reminder is still existing, then we shouldn't have retry
reminder in the scheduler at this point. the tagging will be useful if we want
to differentiate them for a diff purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
