[
https://issues.apache.org/jira/browse/GOBBLIN-2077?focusedWorklogId=921599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921599
]
ASF GitHub Bot logged work on GOBBLIN-2077:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/24 22:17
Start Date: 31/May/24 22:17
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3960:
URL: https://github.com/apache/gobblin/pull/3960#discussion_r1622990585
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -102,6 +103,8 @@ private void submitNextNodes(DagManagementStateStore
dagManagementStateStore, Da
DagProcUtils.submitJobToExecutor(dagManagementStateStore, dagNode,
getDagId());
log.info("Submitted job {} for dagId {}",
DagManagerUtils.getJobName(dagNode), getDagId());
}
+
+
DagProcUtils.sendEnforceFlowFinishDeadlineDagAction(dagManagementStateStore,
getDagTask().getDagAction());
Review Comment:
rather than situating here in `submitNextNodes`, this might better belong
within `act()`... in particular shouldn't it only come after this line (from
`act()`):
```
//Checkpoint the dag state, it should have an updated value of dag nodes
dagManagementStateStore.checkpointDag(dag.get());
```
?
Issue Time Tracking
-------------------
Worklog Id: (was: 921599)
Time Spent: 20m (was: 10m)
> create flow finish deadline dag action after the launch of first job
> --------------------------------------------------------------------
>
> Key: GOBBLIN-2077
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2077
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
