[
https://issues.apache.org/jira/browse/GOBBLIN-2077?focusedWorklogId=921624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921624
]
ASF GitHub Bot logged work on GOBBLIN-2077:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/24 03:17
Start Date: 02/Jun/24 03:17
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3960:
URL: https://github.com/apache/gobblin/pull/3960#discussion_r1623317132
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -146,7 +147,7 @@ public DagTask next() {
}
} catch (Exception e) {
//TODO: need to handle exceptions gracefully
- log.error("Exception getting DagAction from the queue / creating
DagTask", e);
+ log.error("Exception getting DagAction from the queue or creating
DagTask. dagAction - {}", dagAction == null ? "<null>" : dagAction, e);
Review Comment:
NBD, but:
```
log.error("Exception getting DagAction from the queue or creating DagTask.
dagAction - {}", dagAction, e);
```
would, when `dagAction == null`, just result in:
```
Exception getting DagAction from the queue or creating DagTask. dagAction -
null
```
which seems simpler to write and not much different than
```
Exception getting DagAction from the queue or creating DagTask. dagAction -
<null>
```
Issue Time Tracking
-------------------
Worklog Id: (was: 921624)
Time Spent: 40m (was: 0.5h)
> create flow finish deadline dag action after the launch of first job
> --------------------------------------------------------------------
>
> Key: GOBBLIN-2077
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2077
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
