umustafi commented on PR #3952: URL: https://github.com/apache/gobblin/pull/3952#issuecomment-2174209078
> Most of the diff in the PR is because of the refactoring. Can you explain what were the changes that helped get rid of this todo > > ``` > // todo - fix bug of a reminder event getting a lease even when the first attempt succeeded. > // for now, avoid processing reminder events if they are not for deadline dag actions > ``` yes the main change is storing eventTimestamp from the first leaseAttemptStatus in the DagActionReminderScheduler and using that when trying lease on reminder MALA. Otherwise it would use current ts as the eventTimestamp and treat every reminder as new event and do duplicate processing of dagAction once for original once for reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
