[
https://issues.apache.org/jira/browse/GOBBLIN-2016?focusedWorklogId=924954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924954
]
ASF GitHub Bot logged work on GOBBLIN-2016:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/24 05:39
Start Date: 09/Jul/24 05:39
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1669754378
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -129,14 +129,18 @@ public void execute(JobExecutionContext context) {
/**
* Creates a key for the reminder job by concatenating all dagAction fields
and the eventTime of the dagAction to
- * allow reminders for actions associated with multiple flow executions
within a deadline period (e.g. another
- * flow execution may occur before a flow finish or job start deadline
expires)
+ * allow reminders for distinct action requests of the same flow execution
within a deadline period (e.g. multiple
+ * kill requests for the same flow execution).
Review Comment:
when you say "deadline period", that's not related to job-start or
flow-completion deadlines, is it? do you mean "reminder period" (approx. the
'linger' setting)?
also, this is when multiple instances of the same action on the same flow
execution originate more than 'epsilon' apart, right? and it's applicable to
only KILL and RESUME, not other types, correct?
Issue Time Tracking
-------------------
Worklog Id: (was: 924954)
Time Spent: 1h 20m (was: 1h 10m)
> retry retry-able exceptions in DagProcs
> ---------------------------------------
>
> Key: GOBBLIN-2016
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2016
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
