[
https://issues.apache.org/jira/browse/GOBBLIN-2016?focusedWorklogId=925099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925099
]
ASF GitHub Bot logged work on GOBBLIN-2016:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/24 15:43
Start Date: 09/Jul/24 15:43
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1670761623
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -129,14 +129,18 @@ public void execute(JobExecutionContext context) {
/**
* Creates a key for the reminder job by concatenating all dagAction fields
and the eventTime of the dagAction to
- * allow reminders for actions associated with multiple flow executions
within a deadline period (e.g. another
- * flow execution may occur before a flow finish or job start deadline
expires)
+ * allow reminders for distinct action requests of the same flow execution
within a deadline period (e.g. multiple
+ * kill requests for the same flow execution).
Review Comment:
it should be deadline or reminder period and more likely the former will
actually cause the issue bc the SLA deadline (ie: job complete within 2 hours)
is stored in this scheduler and will conflict with another SLA deadline
reminder (job complete within 2 hours) stored in the Scheduler. The same
conflict can also happen with the reminder period.
The latter is precisely correct, yes.
Issue Time Tracking
-------------------
Worklog Id: (was: 925099)
Time Spent: 1.5h (was: 1h 20m)
> retry retry-able exceptions in DagProcs
> ---------------------------------------
>
> Key: GOBBLIN-2016
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2016
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
