arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1675035833
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MySqlDagManagementStateStore.java:
##########
@@ -121,10 +115,10 @@ public synchronized void setTopologySpecMap(Map<URI,
TopologySpec> topologySpecM
start();
}
- private DagStateStore createDagStateStore(Config config, Map<URI,
TopologySpec> topologySpecMap) {
+ private DagNodeStateStore createDagStateStore(Config config, Map<URI,
TopologySpec> topologySpecMap) {
try {
Class<?> dagStateStoreClass =
Class.forName(ConfigUtils.getString(config, DAG_STATESTORE_CLASS_KEY,
MysqlDagStateStore.class.getName()));
Review Comment:
Using dag proc engine is a pre requisite of using MysqlDagStateStoreV2, so
keeping the default class `MysqlDagStateStore`. though it is also set to
MysqlDagStateStore through configs in LI projects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
