arjun4084346 commented on code in PR #3999: URL: https://github.com/apache/gobblin/pull/3999#discussion_r1680058204
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStoreV2.java: ########## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.lang.reflect.Type; +import java.net.URI; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.stream.Collectors; + +import org.eclipse.jgit.errors.NotSupportedException; + +import com.google.gson.JsonDeserializer; +import com.google.gson.JsonSerializer; +import com.google.gson.reflect.TypeToken; +import com.typesafe.config.Config; + +import javax.sql.DataSource; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.broker.SharedResourcesBrokerFactory; +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.configuration.State; +import org.apache.gobblin.instrumented.Instrumented; +import org.apache.gobblin.metastore.MysqlDataSourceFactory; +import org.apache.gobblin.metrics.ContextAwareCounter; +import org.apache.gobblin.metrics.MetricContext; +import org.apache.gobblin.metrics.ServiceMetricNames; +import org.apache.gobblin.runtime.api.TopologySpec; +import org.apache.gobblin.runtime.spec_serde.GsonSerDe; +import org.apache.gobblin.service.ServiceConfigKeys; +import org.apache.gobblin.service.modules.flowgraph.Dag; +import org.apache.gobblin.service.modules.flowgraph.DagNodeId; +import org.apache.gobblin.service.modules.spec.JobExecutionPlan; +import org.apache.gobblin.service.modules.spec.JobExecutionPlanDagFactory; +import org.apache.gobblin.service.modules.spec.JobExecutionPlanListDeserializer; +import org.apache.gobblin.service.modules.spec.JobExecutionPlanListSerializer; +import org.apache.gobblin.util.ConfigUtils; +import org.apache.gobblin.util.DBStatementExecutor; + +import static org.apache.gobblin.service.ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX; +import static org.apache.gobblin.service.modules.orchestration.DagManagerUtils.generateDagId; + + +/** + * An implementation of {@link DagNodeStateStore} using MySQL as a backup. + */ +@Slf4j +public class MysqlDagStateStoreV2 implements DagNodeStateStore { + + public static final String CONFIG_PREFIX = GOBBLIN_SERVICE_PREFIX + "mysqlDagStateStore"; + protected final DBStatementExecutor dbStatementExecutor; + protected final String tableName; + protected final GsonSerDe<List<JobExecutionPlan>> serDe; + private final JobExecutionPlanDagFactory jobExecPlanDagFactory; + + // todo add a column that tells if it is a running dag or a failed dag + protected static final String CREATE_TABLE_STATEMENT = "CREATE TABLE IF NOT EXISTS %s (" + + "dag_node_id VARCHAR(" + ServiceConfigKeys.MAX_DAG_NODE_ID_LENGTH + ") CHARACTER SET latin1 COLLATE latin1_bin NOT NULL, " + + "parent_dag_id VARCHAR(" + ServiceConfigKeys.MAX_DAG_ID_LENGTH + ") NOT NULL, " + + "dag_node JSON, " + + "modified_time timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, " + + "PRIMARY KEY (dag_node_id))"; Review Comment: adding index. you suggested that dag_node_id alone is sufficient for PK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
