[
https://issues.apache.org/jira/browse/GOBBLIN-2113?focusedWorklogId=926229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926229
]
ASF GitHub Bot logged work on GOBBLIN-2113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/24 20:44
Start Date: 16/Jul/24 20:44
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4004:
URL: https://github.com/apache/gobblin/pull/4004#discussion_r1680044655
##########
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/DagActionStoreChangeMonitorTest.java:
##########
@@ -150,7 +150,7 @@ public void
testProcessMessageWithHeartbeatAndNullDagAction() throws SpecNotFoun
@Test (dependsOnMethods = "testProcessMessageWithHeartbeatAndNullDagAction")
public void testProcessMessageWithHeartbeatAndFlowInfo() throws
SpecNotFoundException {
Kafka09ConsumerClient.Kafka09ConsumerRecord consumerRecord =
- wrapDagActionStoreChangeEvent(OperationType.HEARTBEAT, FLOW_GROUP,
FLOW_NAME, FLOW_EXECUTION_ID, DagActionValue.RESUME);
+ wrapDagActionStoreChangeEvent(OperationType.HEARTBEAT, "", "", "",
DagActionValue.RESUME);
Review Comment:
is this a real case? can a heartbeat message not have flow name and have dag
action?
Issue Time Tracking
-------------------
Worklog Id: (was: 926229)
Time Spent: 0.5h (was: 20m)
> Process HB messages with empty FlowExecutionId str
> --------------------------------------------------
>
> Key: GOBBLIN-2113
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2113
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{After changing flowExecutionID from a Str to a long in a previous PR, we
> encounter NumberFormatException in the DagActionStoreChangeMonitor when
> processing HB events. This ends up killing the HighLevelConsumer queues for
> the hosts that receive the HB events in their partition. }}
> {{Encountered exception while processing record so stopping queue processing.
> Record: LiKafka10ConsumerRecord(consumerRecord=ConsumerRecord(topic =
> ds_mysql_makto-db-152_prod_SHARED_GOBBLIN_DAG_ACTION_STORE_20221208211255,
> partition = 0, leaderEpoch = null, offset = 905733, NoTimestampType = -1,
> serialized key size = -1, serialized value size = -1, headers =
> RecordHeaders(headers = [], isReadOnly = false), key = , value =
> \{"changeEventIdentifier": {"key": "", "txId": "", "produceTimestampMillis":
> 1721078158347, "operationType": "HEARTBEAT"}, "flowGroup": "", "flowName":
> "", "flowExecutionId": "", "jobName": "", "dagAction": null})) Exception:
> java.lang.NumberFormatException: For input string: ""}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
