[
https://issues.apache.org/jira/browse/GOBBLIN-2113?focusedWorklogId=926252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926252
]
ASF GitHub Bot logged work on GOBBLIN-2113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/24 22:38
Start Date: 16/Jul/24 22:38
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #4004:
URL: https://github.com/apache/gobblin/pull/4004#discussion_r1680136542
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -112,20 +112,26 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
TimingEvent flowCompilationTimer = new TimingEvent(this.eventSubmitter,
TimingEvent.FlowTimings.FLOW_COMPILED);
Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata(flowSpec);
- Optional<Dag<JobExecutionPlan>> jobExecutionPlanDagOptional =
- validateAndHandleConcurrentExecution(flowConfig, flowSpec, flowGroup,
flowName, flowMetadata);
- if (!jobExecutionPlanDagOptional.isPresent()) {
- return Optional.absent();
- }
+ try {
+ Optional<Dag<JobExecutionPlan>> jobExecutionPlanDagOptional =
+ validateAndHandleConcurrentExecution(flowConfig, flowSpec,
flowGroup, flowName, flowMetadata);
- if (jobExecutionPlanDagOptional.get().isEmpty()) {
- populateFlowCompilationFailedEventMessage(eventSubmitter, flowSpec,
flowMetadata);
- return Optional.absent();
- }
+ if (!jobExecutionPlanDagOptional.isPresent()) {
+ return Optional.absent();
+ }
+
+ if (jobExecutionPlanDagOptional.get().isEmpty()) {
+ populateFlowCompilationFailedEventMessage(eventSubmitter, flowSpec,
flowMetadata);
+ return Optional.absent();
+ }
- flowCompilationTimer.stop(flowMetadata);
- return jobExecutionPlanDagOptional;
+ flowCompilationTimer.stop(flowMetadata);
+ return jobExecutionPlanDagOptional;
+ } catch (IOException e) {
+ log.error("Encountered exception when attempting to compile and perform
checks for flow: {}", flowSpec);
Review Comment:
If you want to log this out maybe only print out the flowspec IDs
Issue Time Tracking
-------------------
Worklog Id: (was: 926252)
Time Spent: 1h 10m (was: 1h)
> Process HB messages with empty FlowExecutionId str
> --------------------------------------------------
>
> Key: GOBBLIN-2113
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2113
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{After changing flowExecutionID from a Str to a long in a previous PR, we
> encounter NumberFormatException in the DagActionStoreChangeMonitor when
> processing HB events. This ends up killing the HighLevelConsumer queues for
> the hosts that receive the HB events in their partition. }}
> {{Encountered exception while processing record so stopping queue processing.
> Record: LiKafka10ConsumerRecord(consumerRecord=ConsumerRecord(topic =
> ds_mysql_makto-db-152_prod_SHARED_GOBBLIN_DAG_ACTION_STORE_20221208211255,
> partition = 0, leaderEpoch = null, offset = 905733, NoTimestampType = -1,
> serialized key size = -1, serialized value size = -1, headers =
> RecordHeaders(headers = [], isReadOnly = false), key = , value =
> \{"changeEventIdentifier": {"key": "", "txId": "", "produceTimestampMillis":
> 1721078158347, "operationType": "HEARTBEAT"}, "flowGroup": "", "flowName":
> "", "flowExecutionId": "", "jobName": "", "dagAction": null})) Exception:
> java.lang.NumberFormatException: For input string: ""}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
