Will-Lo commented on code in PR #3972:
URL: https://github.com/apache/gobblin/pull/3972#discussion_r1683533167
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/predicates/DatasetHiveSchemaContainsNonOptionalUnion.java:
##########
@@ -77,7 +89,13 @@ private DbAndTable getDbAndTable(T dataset) {
"Expected pattern = %s", dataset.getUrn(), pattern.pattern()));
}
- return new DbAndTable(m.group(1),
HiveMetaStoreUtils.getHiveTableName(m.group(2)));
Review Comment:
We need to be cautious here with the line above, if the pattern match
doesn't work it will throw before it runs the lines below. You may want to
avoid throwing until after the secondary check fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
