pawanbtej commented on code in PR #3972:
URL: https://github.com/apache/gobblin/pull/3972#discussion_r1683630550
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/predicates/DatasetHiveSchemaContainsNonOptionalUnion.java:
##########
@@ -77,7 +89,13 @@ private DbAndTable getDbAndTable(T dataset) {
"Expected pattern = %s", dataset.getUrn(), pattern.pattern()));
}
- return new DbAndTable(m.group(1),
HiveMetaStoreUtils.getHiveTableName(m.group(2)));
Review Comment:
If the pattern match doesn't work we won't anyway have the tableName so it
is fine for the 2nd check not to run and exit out saying pattern is not
matching.
As the 2nd check is only for the db, whereas the pattern check is for both
the db and table name and if no table name, no point having just the
optionalDbName present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
