[
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928362
]
ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/24 21:28
Start Date: 01/Aug/24 21:28
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1700888520
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowLaunchHandler.java:
##########
@@ -120,6 +120,24 @@ &&
persistLaunchDagAction((LeaseAttemptStatus.LeaseObtainedStatus) leaseAttempt)
}
}
+ /**
+ * This method is used in the multi-active scheduler case for one or more
hosts to respond to a kill dag action
+ * event triggered by the Orchestrator by attempting a lease for the kill
event and processing the result depending on
+ * the status of the attempt.
+ */
+ public void handleFlowKillTriggerEvent(Properties jobProps,
DagActionStore.LeaseParams leaseParams) throws IOException {
Review Comment:
delete and resume rest commands are actually already creating dag actions as
expected, check FlowExecutionResourceLocalHandler.
this dag kill this PR is addressing is about the expectation that when a
flowConfig is deleted, its dags should also be stopped.
Issue Time Tracking
-------------------
Worklog Id: (was: 928362)
Time Spent: 1h 10m (was: 1h)
> redirect kill requests to dag proc engine
> ------------------------------------------
>
> Key: GOBBLIN-2121
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
