[jira] [Work logged] (GOBBLIN-2121) redirect kill requests to dag proc engine

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928442
 ]

ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/24 09:43
            Start Date: 02/Aug/24 09:43
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1701578156


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngine.java:
##########
@@ -122,6 +134,7 @@ static class DagProcEngineThread implements Runnable {
     private final DagProcFactory dagProcFactory;
     private final DagManagementStateStore dagManagementStateStore;
     private final DagProcessingEngineMetrics dagProcEngineMetrics;
+    private final List<Class<? extends Exception>> nonRetryableExceptions;

Review Comment:
   let's use a predicate as the interface - i.e. a function of `Throwable -> 
boolean`, but you could certainly implement one instance of such a Strategy 
interface in terms of a `List<Class<? extends Exception>>`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 928442)
    Time Spent: 1h 40m  (was: 1.5h)

>  redirect kill requests to dag proc engine
> ------------------------------------------
>
>                 Key: GOBBLIN-2121
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)