[jira] [Work logged] (GOBBLIN-2121) redirect kill requests to dag proc engine

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928575
 ]

ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/24 20:15
            Start Date: 02/Aug/24 20:15
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4015:
URL: https://github.com/apache/gobblin/pull/4015#discussion_r1702280841


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -48,16 +48,16 @@ protected Optional<Dag<JobExecutionPlan>> 
initialize(DagManagementStateStore dag
   @Override
   protected void act(DagManagementStateStore dagManagementStateStore, 
Optional<Dag<JobExecutionPlan>> dag,
       DagProcessingEngineMetrics dagProcEngineMetrics) throws IOException {
+    log.info("Request to enforce {} deadline for dag {}", getDagActionType(), 
getDagId());
     if (isDagStillPresent(dag, dagManagementStateStore)) {
+      // if the job is not already completed and dag action is still present, 
enforce deadline
       enforceDeadline(dagManagementStateStore, dag.get(), 
dagProcEngineMetrics);
-    } else {
-    dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
-  }
+    }
+    dagProcEngineMetrics.markDagActionsAct(getDagActionType(), true);

Review Comment:
   returning true, because this is not a failure in dagActionAct





Issue Time Tracking
-------------------

    Worklog Id:     (was: 928575)
    Time Spent: 3h 10m  (was: 3h)

>  redirect kill requests to dag proc engine
> ------------------------------------------
>
>                 Key: GOBBLIN-2121
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)