[
https://issues.apache.org/jira/browse/GOBBLIN-2124?focusedWorklogId=928609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928609
]
ASF GitHub Bot logged work on GOBBLIN-2124:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/24 01:36
Start Date: 03/Aug/24 01:36
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4016:
URL: https://github.com/apache/gobblin/pull/4016#discussion_r1702429016
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagProcFactory.java:
##########
@@ -48,41 +53,52 @@
@Singleton
public class DagProcFactory implements DagTaskVisitor<DagProc<?>> {
+ private final Config config;
private final FlowCompilationValidationHelper
flowCompilationValidationHelper;
+ private final List<Class<? extends Exception>> nonRetryableExceptions;
@Inject
- public DagProcFactory(FlowCompilationValidationHelper
flowCompilationValidationHelper) {
+ public DagProcFactory(Config config, FlowCompilationValidationHelper
flowCompilationValidationHelper) {
+ this.config = config;
this.flowCompilationValidationHelper = flowCompilationValidationHelper;
+ this.nonRetryableExceptions = ConfigUtils.getStringList(config,
ServiceConfigKeys.DAG_PROC_ENGINE_NON_RETRYABLE_EXCEPTIONS_KEY)
Review Comment:
if i have to pass an argument, i would like to pass something that can be
used for any future requirements, this way param counts will remain in check.
i would prefer to pass `Config` instead of `Predicate`
Issue Time Tracking
-------------------
Worklog Id: (was: 928609)
Time Spent: 1h 10m (was: 1h)
> ignore non-retryable exceptions in dag proc engine
> --------------------------------------------------
>
> Key: GOBBLIN-2124
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2124
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
