[
https://issues.apache.org/jira/browse/GOBBLIN-2124?focusedWorklogId=928781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928781
]
ASF GitHub Bot logged work on GOBBLIN-2124:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/24 21:56
Start Date: 05/Aug/24 21:56
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4016:
URL: https://github.com/apache/gobblin/pull/4016#discussion_r1704668286
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -236,7 +237,7 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
try {
this.dagManagementStateStore.addJobDagAction(flowGroup,
flowName, flowExecutionId, jobName, DagActionStore.DagActionType.REEVALUATE);
} catch (IOException e) {
- if (e.getCause() != null &&
isThrowableInstanceOf(e.getCause(), nonRetryableExceptions)) {
+ if (ExceptionUtils.isExceptionInstanceOf(e,
nonRetryableExceptions)) {
Review Comment:
yes, we only re try adding dag action for transient exceptions, so we want
it to throw exception, so it is retried. if it is not retryable, it should be
swallowed. so the condition looks correct to me...
Issue Time Tracking
-------------------
Worklog Id: (was: 928781)
Time Spent: 2h (was: 1h 50m)
> ignore non-retryable exceptions in dag proc engine
> --------------------------------------------------
>
> Key: GOBBLIN-2124
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2124
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
