[
https://issues.apache.org/jira/browse/GOBBLIN-2137?focusedWorklogId=931009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931009
]
ASF GitHub Bot logged work on GOBBLIN-2137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/24 17:53
Start Date: 20/Aug/24 17:53
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4032:
URL: https://github.com/apache/gobblin/pull/4032#discussion_r1723719637
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/Dag.java:
##########
@@ -48,6 +48,8 @@ public class Dag<T> {
// Map to maintain parent to children mapping.
private Map<DagNode, List<DagNode<T>>> parentChildMap;
private List<DagNode<T>> nodes;
+ @Setter
Review Comment:
because we do not persist dag level field in mysql, adding fields to Dag
will not be much useful and may lead to bugs
Issue Time Tracking
-------------------
Worklog Id: (was: 931009)
Remaining Estimate: 0h
Time Spent: 10m
> Merge Failed Node Dag State Store and Dag Node State Store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2137
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2137
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Merge Failed Node Dag State Store and Dag Node State Store
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
