[
https://issues.apache.org/jira/browse/GOBBLIN-2137?focusedWorklogId=931015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931015
]
ASF GitHub Bot logged work on GOBBLIN-2137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/24 18:46
Start Date: 20/Aug/24 18:46
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4032:
URL: https://github.com/apache/gobblin/pull/4032#discussion_r1723797343
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagStateStoreWithDagNodes.java:
##########
@@ -40,7 +40,8 @@ public interface DagStateStoreWithDagNodes extends
DagStateStore {
* Returns 1 if the dag node is inserted as a new one, 2 if is updated, and
0 if new dag node is same as the existing one
* <a
href="https://dev.mysql.com/doc/refman/8.4/en/insert-on-duplicate.html";>Refer</a>
*/
- int updateDagNode(DagManager.DagId dagId, Dag.DagNode<JobExecutionPlan>
dagNode) throws IOException;
+ int updateDagNode(DagManager.DagId dagId, Dag.DagNode<JobExecutionPlan>
dagNode, boolean isFailedDag) throws IOException;
Review Comment:
isFailedDag is also inside DagNode, right? do we still need isFailedDag as a
separate parameter?
Issue Time Tracking
-------------------
Worklog Id: (was: 931015)
Time Spent: 20m (was: 10m)
> Merge Failed Node Dag State Store and Dag Node State Store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2137
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2137
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Merge Failed Node Dag State Store and Dag Node State Store
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
