Will-Lo commented on code in PR #4047: URL: https://github.com/apache/gobblin/pull/4047#discussion_r1744607251
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/GenerateWorkUnitResult.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.temporal.ddm.work; + +import java.util.HashSet; +import java.util.Set; + +import lombok.Data; +import lombok.NoArgsConstructor; +import lombok.NonNull; +import lombok.RequiredArgsConstructor; + + +/** + * Data structure representing the stats for a committed dataset, and the total number of committed workunits in the Gobblin Temporal job + * Return type of {@link org.apache.gobblin.temporal.ddm.workflow.ProcessWorkUnitsWorkflow#process(WUProcessingSpec)} + * and {@link org.apache.gobblin.temporal.ddm.workflow.CommitStepWorkflow#commit(WUProcessingSpec)}. + */ +@Data +@NoArgsConstructor // IMPORTANT: for jackson (de)serialization +@RequiredArgsConstructor +public class GenerateWorkUnitResult { + @NonNull private int generatedWuCount; + // Optional resources that the Temporal Job Launcher should clean up as a side effect of generating WUs + @NonNull private Set<String> cleanupResources; + + public static GenerateWorkUnitResult createEmpty() { + return new GenerateWorkUnitResult(0, new HashSet<>()); + } Review Comment: I don't think Optional would reflect well in the Temporal UI, I think sending empty results makes more sense especially if there is any aggregations done in the future on activity results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
